Clear Stan suggestion; use fromMaybe mempty not fold

commercialhaskell · Oct 20, 2023 · 7ce7009 · 7ce7009
1 parent 107d205
commit 7ce7009
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/.stan.toml b/.stan.toml
@@ -121,12 +121,6 @@
   scope = "all"
   type = "Exclude"
 
-# Anti-pattern: Foldable methods on possibly error-prone structures
-[[check]]
-  id = "STAN-0207"
-  scope = "all"
-  type = "Exclude"
-
 # Anti-pattern: Slow 'length' for Text
 # On Windows
 [[check]]

diff --git a/src/Stack/Build/Execute.hs b/src/Stack/Build/Execute.hs
@@ -1554,7 +1554,7 @@ withSingleContext ActionContext {..} ee@ExecuteEnv {..} task@Task {..} allDeps m
                     (sinkWithTimestamps prefixWithTimestamps h)
                     (sinkWithTimestamps prefixWithTimestamps h)
                 OTConsole mprefix ->
-                  let prefix = fold mprefix
+                  let prefix = fromMaybe mempty mprefix
                   in  void $ sinkProcessStderrStdout
                         (toFilePath exeName)
                         fullArgs