Skip to content

Commit

Permalink
Merge pull request #6671 from commercialhaskell/tested
Browse files Browse the repository at this point in the history
Bump 'not tested with' to be GHC > 9.11 and Cabal > 3.13
  • Loading branch information
mpilgrem authored Dec 13, 2024
2 parents b8a7fa1 + 37d44dd commit 47b7f38
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Behavior changes:

Other enhancements:

* Consider GHC 9.10 to be a tested compiler and remove warnings.
* Consider Cabal 3.12 to be a tested library and remove warnings.
* Add flags `--run-tests` and `--run-benchmarks` (the existing defaults) to
Stack's `build` command, which take precedence over the existing
`no-run-tests` and `no-run-benchmarks` configuration options, respectively.
Expand Down
8 changes: 4 additions & 4 deletions src/Stack/Setup.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1050,9 +1050,9 @@ warnUnsupportedCompiler ghcVersion = do
, style Url "https://github.com/commercialhaskell/stack/issues/648" <> "."
]
pure True
| ghcVersion >= mkVersion [9, 9] && notifyIfGhcUntested -> do
| ghcVersion >= mkVersion [9, 11] && notifyIfGhcUntested -> do
prettyWarnL
[ flow "Stack has not been tested with GHC versions 9.10 and above, \
[ flow "Stack has not been tested with GHC versions 9.12 and above, \
\and using"
, fromString (versionString ghcVersion) <> ","
, flow "this may fail."
Expand Down Expand Up @@ -1094,9 +1094,9 @@ warnUnsupportedCompilerCabal cp didWarn = do
, parens (style Shell "nightly-2018-03-13")
, flow "or later specify such GHC versions."
]
| cabalVersion >= mkVersion [3, 11] && notifyIfCabalUntested ->
| cabalVersion >= mkVersion [3, 13] && notifyIfCabalUntested ->
prettyWarnL
[ flow "Stack has not been tested with Cabal versions 3.12 and \
[ flow "Stack has not been tested with Cabal versions 3.14 and \
\above, but version"
, fromString (versionString cabalVersion)
, flow "was found, this may fail."
Expand Down

0 comments on commit 47b7f38

Please sign in to comment.