Skip to content

Conversation

@ad1tyayadav
Copy link
Contributor

This pull request fixes issue #142

My previous pull request (#144 ) was accidentally closed because I deleted my fork.
I’ve recreated the fork and pushed the same changes here to continue the discussion.

Sorry for the inconvenience, and thank you for your patience
@ugtthis @sshane

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

deployed preview: https://comma-web--pr146-vrmty054.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

@ugtthis
Copy link
Contributor

ugtthis commented Sep 3, 2025

  • You can refer to my previous review comments in the closed PR (redundant code, and using $page.url.hash from $app/stores)
  • Try not to tag users often since they already get notified from Github and doesn't provide much help. The things that seem to helps the most is really making sure you make the PR as simple as you can. If they can click merge and leave no review comments thats the best type of PR

@ad1tyayadav
Copy link
Contributor Author

make all changes.
can you please review it?

@ad1tyayadav
Copy link
Contributor Author

@ugtthis hey can you please let me know if there is something wrong with this PR?

@sshane sshane requested a review from Copilot October 15, 2025 06:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements functionality to automatically open FAQ accordion items when the URL contains a hash fragment, addressing issue #142. The change replaces the previous onMount approach with a reactive Svelte pattern using the $page store.

  • Replaced onMount lifecycle hook with reactive statement using $page.url.hash
  • Added checked prop to Accordion component to control initial open state
  • Simplified hash handling by removing direct DOM manipulation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sshane sshane merged commit 8ef4439 into commaai:master Oct 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants