fix(flash): correct sector offset for sparse chunks #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incognitojam
commented
Mar 19, 2025
| @@ -283,7 +283,7 @@ export class qdlDevice { | |||
| if (offset % gpt.sectorSize !== 0) { | |||
| throw "qdl - Offset not aligned to sector size"; | |||
| } | |||
| const sector = (partition.start + BigInt(offset)) / BigInt(gpt.sectorSize); | |||
| const sector = partition.start + BigInt(offset / gpt.sectorSize); | |||
There was a problem hiding this comment.
There was a typo in the calculation for the sector to flash the chunk to, causing the wrong sectors to be overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flashing sparse images don't have any test coverage and we don't have a method to read back images from the device yet