Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas gating not effective on inclines #34511

Open
sshane opened this issue Jan 31, 2025 · 0 comments
Open

Gas gating not effective on inclines #34511

sshane opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@sshane
Copy link
Contributor

sshane commented Jan 31, 2025

It is generally clipped to 0 m/s^2 on uphills. Here it should have been -0.8 m/s^2:

https://connect.comma.ai/d9b97c1d3b8c39b2/0000003d--b51267ca5a/179/240

Image

This PR (#33894) was to fix the low speed braking undershooting by not using the MPC max accel constraint, but accel_limits_turns also assumes that the second accel limit is generally positive:

# clip limits, cannot init MPC outside of bounds
accel_limits_turns[0] = min(accel_limits_turns[0], self.a_desired + 0.05)
accel_limits_turns[1] = max(accel_limits_turns[1], self.a_desired - 0.05)

@sshane sshane added the bug label Jan 31, 2025
@sshane sshane added this to the 0.9.8 milestone Jan 31, 2025
@sshane sshane changed the title allowThrottle not effective allowThrottle not effective on inclines Jan 31, 2025
@sshane sshane changed the title allowThrottle not effective on inclines Gas gating not effective on inclines Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants