You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR (#33894) was to fix the low speed braking undershooting by not using the MPC max accel constraint, but accel_limits_turns also assumes that the second accel limit is generally positive:
It is generally clipped to 0 m/s^2 on uphills. Here it should have been -0.8 m/s^2:
https://connect.comma.ai/d9b97c1d3b8c39b2/0000003d--b51267ca5a/179/240
This PR (#33894) was to fix the low speed braking undershooting by not using the MPC max accel constraint, but
accel_limits_turns
also assumes that the second accel limit is generally positive:openpilot/selfdrive/controls/lib/longitudinal_planner.py
Lines 158 to 160 in a5dd2ab
The text was updated successfully, but these errors were encountered: