Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: verify start from stop change #33976

Closed
7 of 20 tasks
sshane opened this issue Nov 9, 2024 · 5 comments
Closed
7 of 20 tasks

Toyota: verify start from stop change #33976

sshane opened this issue Nov 9, 2024 · 5 comments
Labels
car vehicle-specific toyota
Milestone

Comments

@sshane
Copy link
Contributor

sshane commented Nov 9, 2024

Verify the change in #33974.

Check for no insane overshoot on most of the TSS2 platforms:

@sshane sshane added car vehicle-specific toyota labels Nov 9, 2024
@sshane sshane added this to the 0.9.8 milestone Nov 9, 2024
@devimauz

This comment was marked as off-topic.

@sshane
Copy link
Contributor Author

sshane commented Nov 18, 2024

Thanks for the feedback, but this issue is only for the start from stop change we recently made. Braking should still overshoot until I merge commaai/opendbc#1499

@sshane sshane closed this as completed Jan 14, 2025
@sshane
Copy link
Contributor Author

sshane commented Jan 14, 2025

Haven't seen any bad cases/reports!

@devimauz
Copy link

Haven't seen any bad cases/reports!

how many bad report should i do?

@sshane
Copy link
Contributor Author

sshane commented Jan 14, 2025

This issue is about start from stop. We also merged some braking overshoot prevention last month, please provide a route on the latest version of master with issues and I can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific toyota
Projects
None yet
Development

No branches or pull requests

2 participants