Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torqued: misses some carState frames #32964

Open
sshane opened this issue Jul 11, 2024 · 2 comments
Open

torqued: misses some carState frames #32964

sshane opened this issue Jul 11, 2024 · 2 comments
Labels
bug controls controls/planner related

Comments

@sshane
Copy link
Contributor

sshane commented Jul 11, 2024 •
edited
Loading

Would be great if handle_log could take all messages, right now in notebooks you have to feed it CC, CO, and CS messages only when you get a liveLocationKalman message, which is a bunch of extra code.

#32946
@sshane sshane added enhancement bug controls controls/planner related and removed enhancement labels Jul 11, 2024
@adeebshihadeh
Copy link
Contributor

Does this need to be an issue? Does it affect driving?

@sshane
Copy link
Contributor Author

sshane commented Feb 11, 2025 •
edited
Loading

Because we poll on a 20Hz service, we can easily miss low duration 100Hz steeringPressed events, potentially messing up the torqued estimations, though this seems unlikely to have a big effect. @fredyshox what do you think, close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug controls controls/planner related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adeebshihadeh @sshane