Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honda: Remove BOH signal overlap. Add 'ENABLED' in LKAS_HUD. Full coverage of SCM_BUTTONS. Add VALs to Civic 2022 #998

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Honda: Remove BOH signal overlap. Add 'ENABLED' in LKAS_HUD. Full coverage of SCM_BUTTONS. Add VALs to Civic 2022 #998

wants to merge 4 commits into from

Conversation

csouers
Copy link
Contributor

@csouers csouers commented Jan 16, 2024 •
edited

Related to: commaai/openpilot#31022

Adjustments:

  • Remove overlapping signal in LKAS_HUD
  • Define the ENABLED bit for the stock LKAS systems; used by Honda Bosch Radarless and stock ACC.
  • Honda Bosch: Define catch-all signals in SCM_BUTTONS allowing full pass-through/recreation of the frame without reverse engineering all undiscovered signals.
  • Civic 22: Add missing value (VAL) defs for both button signals (cruise and setting)

@csouers csouers mentioned this pull request Jan 16, 2024
Closed
6 tasks
@csouers
Honda: Add LKAS_HUD enabled bit and full signal coverage of SCM_BUTTONS.
69891e3 
* prep buttons frame for intercept via OP

* remove overlapping signal in LKAS_HUD
@csouers csouers changed the title Honda: Fix some LKAS_HUD overlap and add 'ENABLED'. Full coverage of SCM_BUTTONS. Add Civic 22 VALs Honda: Remove BOH signal overlap and add 'ENABLED' in LKAS_HUD. Full coverage of SCM_BUTTONS. Add Civic 22 VALs Feb 24, 2024
@csouers csouers changed the title Honda: Remove BOH signal overlap and add 'ENABLED' in LKAS_HUD. Full coverage of SCM_BUTTONS. Add Civic 22 VALs Honda: Remove BOH signal overlap. Add 'ENABLED' in LKAS_HUD. Full coverage of SCM_BUTTONS. Add VALs to Civic 2022 Mar 21, 2024
@vanillagorillaa vanillagorillaa mentioned this pull request Apr 21, 2024
Closed
@sshane sshane marked this pull request as draft May 22, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@csouers