Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN: Fix Elect_Gear_Shifter Sport Gear value #981

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Dec 1, 2023

The value for Sport gear is wrong in the DBC for EV/HEV/PHEV platforms.

Route ID: 26a38e4bf36bb74a|2023-11-15--10-11-14

Prerequisite of

image

@devtekve
Copy link
Contributor

@adeebshihadeh sorry for the ping but this would make our life nicer on hev platforms <3

@adeebshihadeh
Copy link
Contributor

Where did the old value come from? How many platforms have been checked? Have all three of EV, PHEV, and HEV been checked?

@ghostnetworksolutions
Copy link

I have same car as DevTekVe and would like this change also.

This was my video from above sunny has inputted here to commit to master

@sshane
Copy link
Contributor

sshane commented Dec 20, 2023

No real source for the old values, it was copied from CF_Lvr_Gear in the OG port: commaai/openpilot#1362, commit: commaai/openpilot@e43fa32

@sshane
Copy link
Contributor

sshane commented Dec 21, 2023

Here's a random Ioniq PHEV, it can be both 4 and 8, so we can't remove the 8 signal def:

image


Can you guys try to replicate this so we can understand the meaning? Are there different sport modes? Try to toggle all the gears/sport options and post a route.

If we can verify that 8 is also sport, then we can merge 4 and 8

@sunnyhaibin
Copy link
Contributor Author

@sshane Brought back 8.

@ghostnetworksolutions
Copy link

@sshane

Will there be anything else that is needed to merge this?

@devtekve
Copy link
Contributor

devtekve commented Jun 18, 2024

Here's a random Ioniq PHEV, it can be both 4 and 8, so we can't remove the 8 signal def:

image

Can you guys try to replicate this so we can understand the meaning? Are there different sport modes? Try to toggle all the gears/sport options and post a route.

If we can verify that 8 is also sport, then we can merge 4 and 8

Been a while but this came up again recently :D, I will need to test, but you asked

Are there different sport modes?

Technically, you can either have it on "S" or you can also have it on a specific gear selected (1 thru 6) and that's still sports mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants