Skip to content

Conversation

@mvl-boston
Copy link
Contributor

@mvl-boston mvl-boston commented Sep 17, 2025

Part of a series of PRs to support serial steering cars in dashcam mode. These cars use linbus for steering and thus require a community translation board to convert canbus signals to linbus for the car to understand.

In total, this series would allow dashcam support for 1.2 million additional cars per North American sales statistics.

This PR supports:

  • 16-17 Accord (ACCORD_9G)

Other PRs will support (pending route logs to open):

  • 14-17 MDX (ACURA_MDX_3G)
  • 18-20 MDX (ACURA_MDX_3G_MMR - different dbc / newer steer status)
  • 15-20 TLX (ACURA_TLX_1G)

Note: Hybrid versions of the Accord and MDX additionally require #2671, which is baselined into this PR.

Notes:

  • Used legacy pid, because torque controller did not drive as well.
  • Created new steering control d. steering control c reserved for Singapore Odyssey

@github-actions github-actions bot added DBC signals car related to opendbc/car/ honda car safety vehicle-specific safety code labels Sep 17, 2025
Comment on lines 55 to 56
HondaSerialSteeringCarDocs("Honda Accord 2016-17", "Honda Sensing"),
HondaSerialSteeringCarDocs("Honda Accord Hybrid 2017", "All"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put these in the car port directly. Look at the Toyota SecOC cars as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this change is correct/complete. Not clear on all the aspects of cardocs.

@adeebshihadeh
Copy link
Contributor

We're not really interested in merging support for cars that don't have a path to being upstreamed.

@jyoung8607
Copy link
Collaborator

We're not really interested in merging support for cars that don't have a path to being upstreamed.

Can we reserve judgment on that for now? This PR looks like a Whole Big Thing, but it won't merge that way:

Once the pre-refactors (prefactors?) are done, the extra carrying-cost of a dashcam-mode serial steering car should be down to a single DBC generator template with a single message in it.

We've told community we'll be more permissive about dashcam merges. Let's take another look once the diff is reduced.

@adeebshihadeh
Copy link
Contributor

I'd like to get to a point where carrying these are free, but we are very much not there, as evidenced by the 144 open pull requests in this repo.

Until we get to that point, I absolutely do not want anything in this repo that makes it harder to get upstream-able cars upstreamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code car related to opendbc/car/ DBC signals honda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants