-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Honda: Dashcam support for Accord 9G - serial steering #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 5e7e0cf.
Merge master
opendbc/car/extra_cars.py
Outdated
| HondaSerialSteeringCarDocs("Honda Accord 2016-17", "Honda Sensing"), | ||
| HondaSerialSteeringCarDocs("Honda Accord Hybrid 2017", "All"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put these in the car port directly. Look at the Toyota SecOC cars as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this change is correct/complete. Not clear on all the aspects of cardocs.
|
We're not really interested in merging support for cars that don't have a path to being upstreamed. |
Can we reserve judgment on that for now? This PR looks like a Whole Big Thing, but it won't merge that way:
Once the pre-refactors (prefactors?) are done, the extra carrying-cost of a dashcam-mode serial steering car should be down to a single DBC generator template with a single message in it. We've told community we'll be more permissive about dashcam merges. Let's take another look once the diff is reduced. |
|
I'd like to get to a point where carrying these are free, but we are very much not there, as evidenced by the 144 open pull requests in this repo. Until we get to that point, I absolutely do not want anything in this repo that makes it harder to get upstream-able cars upstreamed. |
Merge updated hybrid long control
Merge more updates from hybrid long control
Part of a series of PRs to support serial steering cars in dashcam mode. These cars use linbus for steering and thus require a community translation board to convert canbus signals to linbus for the car to understand.
In total, this series would allow dashcam support for 1.2 million additional cars per North American sales statistics.
This PR supports:
Other PRs will support (pending route logs to open):
Note: Hybrid versions of the Accord and MDX additionally require #2671, which is baselined into this PR.
Notes: