refactor: button event handling with ButtonEventConfig and ButtonMap #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakethesnake420
force-pushed
the
btn-events
branch
from
5f4e266 to
3085b55
Compare
sshane
reviewed
Sep 8, 2025
Comment on lines
+16
to
+25
| BUTTON_MAPS: list[ButtonMap] = ( | ||
| ButtonMap(ButtonType.accelCruise, CruiseButtons.RES_ACCEL), | ||
| ButtonMap(ButtonType.decelCruise, CruiseButtons.DECEL_SET), | ||
| ButtonMap(ButtonType.mainCruise, CruiseButtons.MAIN), | ||
| ButtonMap(ButtonType.cancel, CruiseButtons.CANCEL) | ||
| ) | ||
| SETTINGS_BUTTON_MAPS: list[ButtonMap] = ( | ||
| ButtonMap(ButtonType.gapAdjustCruise, CruiseSettings.DISTANCE), | ||
| ButtonMap(ButtonType.lkas, CruiseSettings.LKAS) | ||
| ) |
Author
There was a problem hiding this comment.
I changed it to a list so I could index into it without converting to a list because I had an idea but then I changed the create_button_events code so it was not necessary. I don't see why it couldn't be a dict now.
Author
There was a problem hiding this comment.
Actually, a dict would enforce that you can only have 1 button event for a button value which may be restrictive? So for example you could not have it so that pressing the Resume/cancel button creates 2 events, cancel and resume. Do you agree?
Contributor
|
This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a better button event interface. Should be able to simplify gm and toyota logic further.