move car.capnp #1288
Closed
move car.capnp #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
car
deanlee
force-pushed
the
car_move_car_capnp
branch
7 times, most recently
from
ee6d638 to
65c0bf5
Compare
|
@sshane: I might be away from computer for a few days, feel free to take over this PR anytime. |
deanlee
force-pushed
the
car_move_car_capnp
branch
from
65c0bf5 to
a8d5f55
Compare
2 tasks
sshane
force-pushed
the
car_move_car_capnp
branch
from
d5fcdf5 to
a8d5f55
Compare
|
Got it from 87 touched files and 1045-814 to 23 touched files and 792-538 by keeping structs around |
sshane
reviewed
Oct 1, 2024
opendbc/car/car.capnp
Outdated
|
|
||
| # FIXME: OnroadEvent shouldn't be in car.capnp, but can't immediately | ||
| # move due to being referenced by structs in this file | ||
| struct OnroadEvent @0x9b1657f34caf3ad3 { |
There was a problem hiding this comment.
Still need to move this to openpilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.