Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Common DBC for CAN and CAN-FD Platforms #1269

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Sep 24, 2024

Description

This PR introduces a new common DBC file, _hyundai_common.dbc, serving as the base for generating two separate DBC configurations compatible with both CAN and CAN-FD platforms for Hyundai/Kia/Genesis vehicles.

Key Changes

  • Introduction of _hyundai_common.dbc: This file consolidates the signal definitions, enabling streamlined development and maintenance of DBC files for different platform requirements.
  • Platform-Specific Configurations: The common file will facilitate the generation of targeted DBCs, supporting the unique messages of signals of both CAN and CAN-FD platforms.
  • The DBC definitions will remain consistent across both generated DBC files.

Prerequisite of

Supersedes

sunnyhaibin added a commit to sunnypilot/opendbc that referenced this pull request Sep 26, 2024
sunnyhaibin added a commit to sunnypilot/opendbc that referenced this pull request Sep 26, 2024
sunnyhaibin added a commit to sunnypilot/opendbc that referenced this pull request Sep 27, 2024
sunnyhaibin added a commit to sunnypilot/opendbc that referenced this pull request Sep 27, 2024
@sunnyhaibin sunnyhaibin changed the title HKG: DBC for Hyundai Palisade and Kia Telluride 2023-24 (HDA2) HKG: DBC for Hyundai Palisade and Kia Telluride 2023-24 Sep 27, 2024
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 14, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Nov 22, 2024
@sunnyhaibin
Copy link
Contributor Author

@adeebshihadeh @sshane this one too, can we please reopen this PR?

@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Dec 7, 2024
@sunnyhaibin sunnyhaibin changed the title HKG: DBC for Hyundai Palisade and Kia Telluride 2023-24 Hyundai: Common DBC for CAN and CAN-FD Platforms Dec 7, 2024
@github-actions github-actions bot removed the stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ DBC signals hyundai
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants