Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: hide FCA Errors #1206

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Hyundai: hide FCA Errors #1206

wants to merge 4 commits into from

Conversation

DerGue69
Copy link

Some cars show an FCA fault when forwarding CF_Lkas_FusionState.
Especially with Kia Niro MY19

Some cars show an FCA fault when forwarding. Especially Kia Niro EV MY 19
Some cars show an FCA fault when forwarding CF_Lkas_FusionState. Hide FCA Fault
Some cars show an FCA fault when forwarding CF_Lkas_FusionState. Hide FCA Fault
@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@adeebshihadeh adeebshihadeh changed the title Hide FCA Errors Hyundai: hide FCA Errors Aug 30, 2024
@adeebshihadeh
Copy link
Contributor

Is the fault real? We don't want to just mask the fault.

@DerGue69
Copy link
Author

Is the fault real? We don't want to just mask the fault.

I worked with sshane for a long time on this issue.
see e.g. #1117

I tried to understad data with cabana to see what causes the warning.
I even tried a real-world crash test with the "fix" applied. But lack of professional equipment, we were not able to trigger the front collission assistance.

I am driving with that one line added since ~20k miles with my fork https://github.com/DerGue69/openpilot/tree/master.

@adeebshihadeh
Copy link
Contributor

This needs more validation. Marking as draft for now.

@adeebshihadeh adeebshihadeh marked this pull request as draft August 31, 2024 17:29
@DerGue69
Copy link
Author

This needs more validation. Marking as draft for now.

I am willing to help / test things if you want me. Just ping me and I will do whatever you want me to do. (except crashing car ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants