Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toyota: API is now gas/brake #1189

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Toyota: API is now gas/brake #1189

wants to merge 19 commits into from
+56 −5

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Aug 27, 2024 •
edited
Loading

Needs testing, required for commaai/openpilot#33384

Past PRs for history: commaai/openpilot#29481 // commaai/openpilot#32753

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Aug 27, 2024
@sshane sshane marked this pull request as draft August 27, 2024 06:02
sshane
sshane commented Aug 28, 2024
View reviewed changes
Copy link
Contributor Author

@sshane sshane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longcontrol.py resets the integral every time you disengage, so it may take a few seconds before it learns the offset on each engagement, issue should be on GM (gas/brake) as well

@sshane
Copy link
Contributor Author

sshane commented Sep 14, 2024

There is an undefined signal in CLUTCH that describes a very similar attribute, but may not be affected by the ACC_BRAKING bit?

BO_ 865 CLUTCH: 8 XXX
 SG_ TRUE_ACCEL_REQ : 48|16@1+ (0.0002,-6.5536) [0|4095] "" XXX

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car related to opendbc/car/ DBC signals toyota
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane