Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM: Car Port for XT4 2023 #1177

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Conversation

garrettpall
Copy link
Contributor

@garrettpall garrettpall commented Aug 20, 2024

Car
Cadillac XT4 2023

Route
162796f1469f2f1b/00000005--6f334eda14

Checklist

  • added entry to CarInfo in opendbc/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 162796f1469f2f1b/00000005--6f334eda14
  • route with stock system: 162796f1469f2f1b/00000003--79f5d5854f (old harness design)
  • car harness used (if comma doesn't sell it, put N/A): N/A GM SDGM Harness openpilot#32471

Supersedes commaai/openpilot#30420

@github-actions github-actions bot added car related to opendbc/car/ gm labels Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@adeebshihadeh
Copy link
Contributor

This ports looks smaller than I remember? If this is it, I think we're good to merge it.

@garrettpall
Copy link
Contributor Author

This ports looks smaller than I remember? If this is it, I think we're good to merge it.

Let me test it on Friday. I haven’t tested since the switch of cars to opendbc. But the smaller port is due to an updated harness design (intercept different pins).

@adeebshihadeh
Copy link
Contributor

Converting to draft until then. We should also update the test route.

@adeebshihadeh adeebshihadeh marked this pull request as draft August 27, 2024 23:49
@garrettpall
Copy link
Contributor Author

Tested with car moved to opendbc. Everything works as expected.

Route: 162796f1469f2f1b/0000009d--717c2e1c0a

(note: I have a SASCM (sdsu variant) installed that broadcasts 767, 4, this was added to the fingerprint for testing locally but should not be included upstream. This route demonstrates the port works, the route in the PR should be used as good, clean data)

@garrettpall garrettpall marked this pull request as ready for review August 30, 2024 19:51
@adeebshihadeh adeebshihadeh merged commit 227908e into commaai:master Aug 31, 2024
3 checks passed
@jyoung8607
Copy link
Collaborator

CI test route still needs to be uploaded:

image

@garrettpall garrettpall deleted the xt4-port branch September 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint gm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants