-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM: Car Port for XT4 2023 #1177
Conversation
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
|
This ports looks smaller than I remember? If this is it, I think we're good to merge it. |
Let me test it on Friday. I haven’t tested since the switch of cars to opendbc. But the smaller port is due to an updated harness design (intercept different pins). |
Converting to draft until then. We should also update the test route. |
Tested with Route: (note: I have a SASCM (sdsu variant) installed that broadcasts |
Car
Cadillac XT4 2023
Route
162796f1469f2f1b/00000005--6f334eda14
Checklist
selfdrive/car/docs.py
to generate new docsSupersedes commaai/openpilot#30420