parser: declutter nanos usage #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
added a commit
to deanlee/opendbc
that referenced
this pull request
Jul 31, 2024
thought there'd be more
sshane
added a commit
that referenced
this pull request
Jul 31, 2024
* move car interfaces to opendbc * Revert "move car interfaces to opendbc" This reverts commit 0589ea0. * remove dependence on cereal * parse can strings in a c++ helper function * remove all cereal * reserve * use itervalues * rebase master * cleanup * keep the same style * revert unrelated changes * truly no cereal! * same capitalization same capitalization * parser: declutter nanos usage (#1067) thought there'd be more * revert more --------- Co-authored-by: Shane Smiskol <[email protected]>
martinl
pushed a commit
to martinl/opendbc
that referenced
this pull request
Aug 29, 2024
thought there'd be more
martinl
pushed a commit
to martinl/opendbc
that referenced
this pull request
Aug 29, 2024
* move car interfaces to opendbc * Revert "move car interfaces to opendbc" This reverts commit 0589ea0. * remove dependence on cereal * parse can strings in a c++ helper function * remove all cereal * reserve * use itervalues * rebase master * cleanup * keep the same style * revert unrelated changes * truly no cereal! * same capitalization same capitalization * parser: declutter nanos usage (commaai#1067) thought there'd be more * revert more --------- Co-authored-by: Shane Smiskol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added here: 87af8c4
it's the same thing
After #934 we can clean a bunch more up here