Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexus ES: overshoots start from stop maneuvers #1462

Closed
sshane opened this issue Nov 8, 2024 · 1 comment
Closed

Lexus ES: overshoots start from stop maneuvers #1462

sshane opened this issue Nov 8, 2024 · 1 comment

Comments

@sshane
Copy link
Contributor

sshane commented Nov 8, 2024

I cannot reproduce the nice starts shown in the latest Lexus ES report I gathered before merging #1303:

https://commaai.github.io/opendbc-data/longitudinal_reports/LEXUS_ES_TSS2_57048cfce01d9625_00000208--c387e67187.html

What the route in the report is doing is setting the permit braking bit when the slow rate limited accel request > 0, but on master it sets permit braking immediately once the maneuver starts, causing a bunch of overshoot (similar to our Corolla! are they more similar than I had thought?).

Revert back to this behavior, or #1453 should fix this.

@sshane
Copy link
Contributor Author

sshane commented Nov 8, 2024

I see what might have happened. I must have gotten the maneuver report while on the first commit of #1301 which sets permit braking based on the rate limited acceleration, but then realized it should be based on pitch and switched it before merging. This is fundamentally different than what I tested though, as that accel request signal isn't rate limited.

See the difference (this is setting permit braking using the rate limited accel, what I first tested. This is on a Camry Hybrid which has a massive overshoot with the code on master, here it's fine!):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant