-
-
Notifications
You must be signed in to change notification settings - Fork 417
Simple YAML-backed modules and single-file script modules, second iteration #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lihaoyi
wants to merge
139
commits into
com-lihaoyi:main
Choose a base branch
from
lihaoyi:single-file-projects-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,954
−806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll (com-lihaoyi#5820)"" This reverts commit 72db1f3.
3274207
to
0059443
Compare
36dd7ee
to
d301f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different implementation of #5836, that uses code-generation to treat
build/package.mill.yaml
files as normalbuild/package.mill
modules, rather than as external modules.Advantages:
trait
modules without needing to package them up into specialclass
es, so it can be applied much more generally to dozens oftrait
s available in the Mill librariesextends: [mill.javalib.JavaModule, mill.javalib.PublishModule]
build/package.mill.yaml
can interop much more cleanly withbuild/package.mill
files, including type-safe references in either directionDisadvantages:
class
es, as the ad-hoc nature of scripts means they may live in arbitrary files that are only discovered pretty late (e.g in the middle of execution of ashow
command that resolves things) that cannot be easily discovered during Mill'swalkBuildFiles
stepmain
methods. This could be added in future