Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: CRI: Test all calculated data #1338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

tests: CRI: Test all calculated data #1338

wants to merge 1 commit into from

Conversation

cmuellner
Copy link

Summary

Currently, the CRI test function only tests a subset of the calculated
data. The attribute Q_a and the colorimetry data are not tested,
although the reference data object has reference values.
This patch adds the missing tests.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@cmuellner
tests: CRI: Test all calculated data
e4908a3 
Currently the CRI test function only tests a subset of the calculated
data. The attribute `Q_a` and the colorimetry data are not tested,
although the reference data object has reference values.
This patch adds the missing tests.

Signed-off-by: Christoph Müllner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmuellner