WIP Fix reindex if an attribute is removed from an object #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an attribute becomes None, then the previous code would not have updated the attribute value in the index and the previous value would have lingered indefinitely. This is a second variety fix which instead of unindexing the whole object, just removes all attributes that are not in the data. Caveat: currently effective only on string and text field types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an attribute becomes None, then the previous code would not have
updated the attribute value in the index and the previous value would
have lingered indefinitely.
This is a second variety fix which instead of unindexing the whole
object, just removes all attributes that are not in the data.
Caveat: currently effective only on string and text field types.