Skip to content

Commit

Permalink
Preparing release 6.0.alpha0
Browse files Browse the repository at this point in the history
  • Loading branch information
@tomgross
tomgross committed Oct 5, 2016
1 parent 7d14fb5 commit c21a35f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CHANGES.rst
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Changelog
=========

6.0 (unreleased)
------------------
6.0.alpha0 (2016-10-05)
-----------------------

- New flag: Ignore exceptions that occur during reindexing.
Ignoring exceptions becomes the default when running solr_reindex.
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from setuptools import setup
from setuptools import find_packages

version = '5.0.4.dev0'
version = '6.0.alpha0'

long_description = '\n\n'.join([
open('README.rst').read(),
Expand Down

3 comments on commit c21a35f

@tisto
Copy link
Member

@tisto tisto commented on c21a35f Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomgross was that an internal release? you did it on master but there is not pypi release. "6.0.alpha0" violates our versioning best practice which would be "6.0a1".

@tomgross
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto Since there was no other option I had to do this release for my training in boston. It is only on github (https://github.com/collective/collective.solr/releases/tag/6.0a0) and not on pypi.
According to PEP440 alpha is equivalent to the a-version identifier.
I would be more than happy to use an official, best practice release for the training if it is available in the next couple of days.

@tisto
Copy link
Member

@tisto tisto commented on c21a35f Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomgross ok, next time I'd do that in a branch to not to pollute master. PEP440 does not matter here, we choose one single best practice to be consistent. "alpha" should not be used for plone packages. I will try to make a release in the next days...

Please sign in to comment.