Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #78

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Various updates #78

merged 6 commits into from
Feb 24, 2024

Conversation

sjoerdsimons
Copy link
Contributor

Add send bound on traits for easier usage, update gitlab ci, adds some docs, fix some clippy warnings

actions-rs is deprecated, move to dtolnay/rust-toolchain instead.

Fixes: #56

Signed-off-by: Sjoerd Simons <[email protected]>
Not having the Send bound on the AsyncSeekForward trait in principle
makes it easier to match. However it limits where the async copy can be
used quite a bit. In particular it means it can't be used in a
tokio::spawn, which is rather a big disadvantage.

So start Send for the trait...

Signed-off-by: Sjoerd Simons <[email protected]>
Bump minor as the trait bounds have changed

Signed-off-by: Sjoerd Simons <[email protected]>
Claps MSRV is quite aggressive, pin it to 4.4.x to allow building with
rust 1.70 as currently present in debian testing.

Signed-off-by: Sjoerd Simons <[email protected]>
Signed-off-by: Sjoerd Simons <[email protected]>
@sjoerdsimons sjoerdsimons added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit 1ed4d5e Feb 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant