Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing ssl for server and client; #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stkr22
Copy link

@stkr22 stkr22 commented Feb 11, 2024

I'm using a cloud server to transcribe parts of the audio and thus encryption of the connection is vital for me. I simply implemented options for server and client to get additional ssl context. If left as in the default it will work as before. It should work with both self-signed certificates and regular CAs. I tested it locally.

):
self.client = Client(host, port, lang, translate, model)
self.client = Client(host, port, lang, translate, model, secure_websocket, sslopt)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.client = Client(host, port, lang, translate, model, secure_websocket, sslopt)
self.client = Client(host, port, lang, translate, model,
secure_websocket=secure_websocket, ssl_opts=sslopt)

I see that ssl_opts would be none if we dont pass these as named params because srt_file_path which is an arg in the Client init method and not being passed from TranscriptionClient but dont worry about it we will update this in the another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants