Skip to content

Commit

Permalink
Merge pull request cc65#2380 from colinleroy/asm-fgetc
Browse files Browse the repository at this point in the history
Rewrite fgetc in asm
  • Loading branch information
mrdudz authored Jan 26, 2024
2 parents ba6f9f5 + 476591e commit 6593768
Show file tree
Hide file tree
Showing 4 changed files with 161 additions and 58 deletions.
4 changes: 4 additions & 0 deletions include/stdio.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ extern FILE* stderr;
# define FILENAME_MAX (80+1)
#elif defined(__TELESTRAT__)
# define FILENAME_MAX (50+1)
#elif defined(__SIM6502__)
# define FILENAME_MAX (1024+1)
#elif defined(__SIM65C02__)
# define FILENAME_MAX (1024+1)
#else
# define FILENAME_MAX (16+1)
#endif
Expand Down
58 changes: 0 additions & 58 deletions libsrc/common/fgetc.c

This file was deleted.

92 changes: 92 additions & 0 deletions libsrc/common/fgetc.s
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
;
; Colin Leroy-Mira, 2024
;
; int __fastcall__ fgetc (register FILE* f)
;

.export _fgetc
.import _read, pusha0, pushax, popptr1, incsp2, returnFFFF
.importzp ptr1

.include "stdio.inc"
.include "_file.inc"

_fgetc:
sta ptr1
stx ptr1+1
jsr pushax ; Backup our ptr

ldy #_FILE::f_flags
lda (ptr1),y
tax
and #_FOPEN ; Check for file open
beq ret_eof
txa
and #(_FERROR|_FEOF); Check for error/eof
bne ret_eof

txa
and #_FPUSHBACK ; Check for pushed back char
beq do_read

txa
and #<(~_FPUSHBACK) ; Reset flag
sta (ptr1),y

.assert _FILE::f_pushback = _FILE::f_flags+1, error
iny
jsr incsp2 ; Drop our ptr copy
lda (ptr1),y ; Return pushed back char
ldx #$00
rts

do_read:
; Push _read parameters
ldy #_FILE::f_fd
lda (ptr1),y
jsr pusha0

lda #<c
ldx #>c
jsr pushax

lda #$01
ldx #$00

; Read
jsr _read

; Check for errors
cmp #$00
beq set_feof

cmp #<(-1)
beq set_ferror

jsr incsp2
; Return char
ldx #$00
lda c
rts

ret_eof:
jsr incsp2
jmp returnFFFF

set_ferror:
lda #_FERROR
bne set_err
set_feof:
lda #_FEOF
set_err:
pha
jsr popptr1
pla
ldy #_FILE::f_flags
ora (ptr1),y
sta (ptr1),y
jmp returnFFFF

.bss

c: .res 1
65 changes: 65 additions & 0 deletions test/ref/test_fgets.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
!!DESCRIPTION!! fgets test
!!LICENCE!! Public domain
*/

#include "common.h"

#include <ctype.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

FILE *in, *out;
char buf[32];

#define INFILE "cf.in"

int main(int argc,char **argv)
{
static char outfile_path[FILENAME_MAX+1];

sprintf(outfile_path, "%s.test.out", argv[0]);

out = fopen(outfile_path, "wb");
if (out == NULL) {
return EXIT_FAILURE;
}
if (fgets(buf, sizeof(buf), out) != NULL) {
printf("Error, could fgets with write-only file\n");
return 1;
}
if (!ferror(out)) {
printf("Error: file pointer should be in error state\n");
}
fclose(out);

in = fopen(INFILE, "rb");
if (in == NULL) {
return EXIT_FAILURE;
}

if (fgets(NULL, 0, in) != NULL) {
printf("Error, could fgets with zero size\n");
return 1;
}

/* Test ungetc while we're at it */
buf[0] = fgetc(in);
ungetc(buf[0], in);


while (fgets(buf, sizeof(buf), in) != NULL)
{
printf("%s",buf);
}

if (!feof(in))
{
printf("We should have EOF!\n");
}

fclose(in);
return 0;
}

0 comments on commit 6593768

Please sign in to comment.