Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(routes): routes optimization #5

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

B3ns44d
Copy link

@B3ns44d B3ns44d commented Dec 6, 2021

ref routes(screens/tabs) component

ImgBotApp and others added 2 commits November 19, 2021 07:14
*Total -- 347.02kb -> 181.37kb (47.74%)

/ios/Coingrig/Images.xcassets/AppIcon.appiconset/1024.png -- 38.42kb -> 7.27kb (81.07%)
/AppIcons/appstore.png -- 38.42kb -> 7.27kb (81.07%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/1024.png -- 38.42kb -> 7.27kb (81.07%)
/src/assets/logo.png -- 19.72kb -> 6.61kb (66.49%)
/src/assets/logo_small.png -- 7.98kb -> 3.56kb (55.43%)
/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png -- 5.12kb -> 2.68kb (47.73%)
/AppIcons/playstore.png -- 19.60kb -> 10.53kb (46.25%)
/android/app/src/main/res/drawable/playstore.png -- 19.60kb -> 10.53kb (46.25%)
/ios/Coingrig/Images.xcassets/playstore.imageset/playstore.png -- 19.60kb -> 10.53kb (46.25%)
/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png -- 3.62kb -> 2.06kb (43.26%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/120.png -- 3.15kb -> 1.90kb (39.59%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/120.png -- 3.15kb -> 1.90kb (39.59%)
/android/app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png -- 2.33kb -> 1.46kb (37.28%)
/src/assets/coins/bnb.png -- 1.84kb -> 1.19kb (35.11%)
/AppIcons/android/mipmap-xxxhdpi/ic_launcher.png -- 5.86kb -> 3.80kb (35.1%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/114.png -- 3.00kb -> 1.98kb (33.97%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/114.png -- 3.00kb -> 1.98kb (33.97%)
/AppIcons/android/mipmap-xxhdpi/ic_launcher.png -- 4.34kb -> 3.00kb (30.8%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/87.png -- 2.35kb -> 1.64kb (30.22%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/87.png -- 2.35kb -> 1.64kb (30.22%)
/android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png -- 1.68kb -> 1.19kb (29.3%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/180.png -- 5.09kb -> 3.63kb (28.67%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/180.png -- 5.09kb -> 3.63kb (28.67%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/80.png -- 2.21kb -> 1.61kb (27.26%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/80.png -- 2.21kb -> 1.61kb (27.26%)
/AppIcons/android/mipmap-xhdpi/ic_launcher.png -- 2.72kb -> 2.03kb (25.56%)
/src/assets/more.png -- 0.70kb -> 0.53kb (24.55%)
/src/assets/coins/btc.png -- 4.20kb -> 3.22kb (23.37%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/57.png -- 1.66kb -> 1.28kb (22.42%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/57.png -- 1.66kb -> 1.28kb (22.42%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/60.png -- 1.68kb -> 1.33kb (21.1%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/60.png -- 1.68kb -> 1.33kb (21.1%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/58.png -- 1.61kb -> 1.29kb (20.21%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/58.png -- 1.61kb -> 1.29kb (20.21%)
/src/assets/coins/eth.png -- 3.38kb -> 2.73kb (19.31%)
/AppIcons/android/mipmap-hdpi/ic_launcher.png -- 2.18kb -> 1.76kb (19.25%)
/android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png -- 1.09kb -> 0.88kb (18.83%)
/android/app/src/main/ic_launcher-playstore.png -- 9.92kb -> 8.24kb (16.93%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/40.png -- 1.19kb -> 1.06kb (11.07%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/40.png -- 1.19kb -> 1.06kb (11.07%)
/src/assets/arrows.png -- 0.70kb -> 0.64kb (9.19%)
/AppIcons/android/mipmap-mdpi/ic_launcher.png -- 1.49kb -> 1.36kb (8.89%)
/ios/Coingrig/Images.xcassets/AppIcon.appiconset/29.png -- 0.85kb -> 0.83kb (2.54%)
/AppIcons/Assets.xcassets/AppIcon.appiconset/29.png -- 0.85kb -> 0.83kb (2.54%)
/src/assets/coins/doge.png -- 11.15kb -> 10.88kb (2.43%)
/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png -- 10.55kb -> 10.46kb (0.92%)
/src/assets/svg/crypto.svg -- 8.70kb -> 8.62kb (0.88%)
/src/assets/svg/privacy.svg -- 11.40kb -> 11.30kb (0.87%)
/src/assets/svg/finance.svg -- 6.73kb -> 6.69kb (0.62%)

Signed-off-by: ImgBotApp <[email protected]>
@rvulpescu
Copy link
Member

@B3ns44d We really appreciate your interest and your effort!

At the moment, we're in process of updating the app. We do indeed need refactoring, but at the moment we are launching features in short interval and the app is subject to quick changes.
Please wait for the next version to be released in the next few days.

We're also updating our contributors policy so that we can accept your contribution in the project. We'll have details about this soon.

@rvulpescu rvulpescu changed the base branch from master to develop December 7, 2021 08:43
florindumitru and others added 5 commits December 10, 2021 10:48
 interactive rebase in progress; onto b4d1644
 Last command done (1 command done):
    pick 181f531 ref(routes): routes optimization
 Next command to do (1 remaining command):
    pick bd406b2 ref: routes components to their own files
 You are currently rebasing branch 'coingrig-master' on 'b4d1644'.

 Changes to be committed:
	modified:   App.js
	modified:   src/i18n/index.js
	new file:   src/router/router.tsx
	new file:   src/router/utils/components/Icon.tsx
	new file:   src/router/utils/index.tsx
	new file:   src/router/utils/screens.ts
	new file:   src/router/utils/tabs.ts
 Conflicts:
	App.js
	src/routes.tsx
[ImgBot] Optimize images
@B3ns44d
Copy link
Author

B3ns44d commented Jan 22, 2022

@rvulpescu any news about this pr?

H4TIEL pushed a commit to H4TIEL/mobile-wallet that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants