-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Publish illustrations 2026-01-15 #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
||||||||
| ui-systems-illustrators |
🟡
0/1
|
Denominator calculation
|
twashdesign938
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
Review Error for twashdesign938 @ 2026-01-16 00:18:50 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maximo-macchi-cb we want the themeable variants to be added now right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The themeable SVGs have always been included in the generated output! You can check the src/generated/spotSquare/svg/themeable directory to see all of them (along with all the illustration variants we offer). We just don't currently offer the theming functionality
|
Review Error for twashdesign938 @ 2026-01-16 15:42:49 UTC |
What changed? Why?
This PR updates our illustrations by adding borrowCoinsBtc, test, and goldSilverFutures.
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false