chore: clean up examples #434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
jazz-cb
reviewed
Sep 5, 2025
| @@ -1,6 +1,4 @@ | |||
| # Usage: uv run python evm/swaps/account.quote_swap.py | |||
Contributor
There was a problem hiding this comment.
why do we have account. prefix on some examples ?
jazz-cb
reviewed
Sep 5, 2025
| const owner = privateKeyToAccount(privateKey); | ||
| const owner = await cdp.evm.getOrCreateAccount({ name: "SmartAccountOwner" }); | ||
|
|
||
| let smartAccount = await cdp.evm.createSmartAccount({ owner }); |
Contributor
There was a problem hiding this comment.
also set a known name?
const owner = await cdp.evm.getOrCreateSmartAccount({ name: "SmartAccount", owner });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates example scripts across the repository to improve consistency and usability:
getOrCreateAccount()instead of generating random private keys, making examples more consistent and easier to followThese changes ensure that all examples can be run directly from their locations with the correct paths and follow consistent patterns.