-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fix for cpp-restsdk #130
base: master
Are you sure you want to change the base?
Conversation
BadRequestException was being thrown due to "Wrong format of time_start parameter" in Ohlcv_historical_data(string, string, DateTime, DateTime, int). The data format was hard-coded to "yyyy-MM-dd HH:ss:mm", which is invalid. It was changed to dateFormat, which is what it appears to have been changed to in all other methods.
Corrections, no semi-colons in python, please
add oms directory
* Update CoinApiWsClient.cs * Update CoinAPI.WebSocket.V1.csproj
* Update Symbol.cs * Update CoinAPI.REST.V1.csproj
* support for reconnecting has been added * Update pom.xml Co-authored-by: Artur Pietrzyk <[email protected]>
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. As ModelBase was auto generated, the real fix should be addressed by OpenAPI-Generator.
This should fix these errors:
|
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. This should fix compilation errors on generated source code. See coinapi/coinapi-sdk#130
A patch was submitted to OpenAPITools/openapi-generator#12247 |
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. This should fix compilation errors on generated source code. See coinapi/coinapi-sdk#130
This do not make sense to merge it as it will be replaced again with the openapi generator on the next change. Good to see that the fix was merged in the generator repository; lets keep this open to not lose information that this is a known issue. |
Yes, once it will be regenerated with the latest openapi generator, it will be fixed. |
819b4fc
to
ded59d3
Compare
A specialization for the
shared_ptr<datetime>
data type was added toModelBase member functions fromString, fromJson, toJson and
toHttpContent.
As ModelBase was auto generated, the real fix should be addressed by
OpenAPI-Generator.