Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the counter of the downloads of the desktop app #257

Open
petrvecera opened this issue Oct 3, 2023 · 2 comments
Open

Improve the counter of the downloads of the desktop app #257

petrvecera opened this issue Oct 3, 2023 · 2 comments
Labels
free-to-grab For anyone who wants to take it. good first issue Good for newcomers hacktoberfest

Comments

@petrvecera
Copy link
Member

Currently we have page https://coh3stats.com/desktop-app which shows amount of downloads.

image

However this counts only latest release from https://github.com/cohstats/coh3-stats-desktop-app/releases

We want to count downloads of all the latest releases.
We are counting it here https://github.com/cohstats/coh3-stats/blob/master/pages/desktop-app.tsx#L91

The API link looks like this
https://api.github.com/repos/cohstats/coh3-stats-desktop-app/releases
In the code we use https://api.github.com/repos/cohstats/coh3-stats-desktop-app/releases/latest
Which means that we might want to remove /latest from the code.

Now it will return array of objects instead of single object.

Implementation:

  1. We need to have the latest release and properly set the download link
  2. We want to count downloads from all the old assets too
    • Keep in mind that we need to filter assets which are .sig as we have in the code.

If you have any questions feel free to ask.

@petrvecera petrvecera added good first issue Good for newcomers hacktoberfest free-to-grab For anyone who wants to take it. labels Oct 3, 2023
@Vijeth56
Copy link

Vijeth56 commented Oct 3, 2023

I would like to work on this issue.
Please assign this to me.

@petrvecera
Copy link
Member Author

@Vijeth56 please let me know if you will have time to look at your MR #265

Or someone else can look into it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
free-to-grab For anyone who wants to take it. good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants