Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - the dev warning is too big on mobile #210

Closed
petrvecera opened this issue Jun 11, 2023 · 5 comments
Closed

Bug - the dev warning is too big on mobile #210

petrvecera opened this issue Jun 11, 2023 · 5 comments
Assignees
Labels
bug Something isn't working free-to-grab For anyone who wants to take it. good first issue Good for newcomers hacktoberfest

Comments

@petrvecera
Copy link
Member

petrvecera commented Jun 11, 2023

We have warning in case you visit dev.coh3stats.com that you should not sue that site.
But the warning is too big on mobile and doesn't fit the screen.

image

We need to fix that https://github.com/cohstats/coh3-stats/blob/master/components/dev-site-notification.tsx

Maybe limit the width of the dialog with size https://mantine.dev/core/dialog/?t=props

@petrvecera petrvecera added the bug Something isn't working label Jun 11, 2023
@petrvecera petrvecera added hacktoberfest free-to-grab For anyone who wants to take it. good first issue Good for newcomers labels Oct 2, 2023
@apikmeister
Copy link
Contributor

Hi, I would like to work on this. Can you assign this to me?

@apikmeister
Copy link
Contributor

Hi, i've just tested for the warning dialog. It seems fine to me on smaller to extra small screen.
Screenshot 2023-10-16 at 1 48 10 PM

@petrvecera
Copy link
Member Author

Hi @apikmeister it looks like it was a bug in underlaying library which we used. I recently updated it and it probably fixed it.
If you are interested I am planning a new tasks which can be worked on. I can tag you in case you would like to work on it.

@apikmeister
Copy link
Contributor

I would love to, thank you!

@petrvecera
Copy link
Member Author

@apikmeister if you are interested #272 or #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working free-to-grab For anyone who wants to take it. good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants