Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): make react-components compatible with 360-CDM-changes in Reveal and bump to 0.74.0 #4959

Merged
merged 21 commits into from
Jan 23, 2025
Merged

fix(react-components): make react-components compatible with 360-CDM-changes in Reveal and bump to 0.74.0 #4959

merged 21 commits into from
Jan 23, 2025

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Fixes according to minor breaking changes in the viewer

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite marked this pull request as ready for review January 20, 2025 09:14
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner January 20, 2025 09:14
@haakonflatval-cognite haakonflatval-cognite force-pushed the hflatval/react-components-360-conforming branch from 3e06cd2 to c7cf431 Compare January 20, 2025 14:30
danpriori
danpriori requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few comments with suggestions. But it looks good overall!
I also liked that you have allocated some time to organize our types, type guards and utility functions in order to have a better structure in our code. Love it!
I'm gonna test it more with https://github.com/cognitedata/fusion/pull/10929 during this week.

react-components/src/components/CacheProvider/AnnotationModelUtils.ts Outdated Show resolved Hide resolved
react-components/src/components/CacheProvider/Image360AnnotationCache.ts Outdated Show resolved Hide resolved
react-components/src/components/CacheProvider/utils.ts Show resolved Hide resolved
react-components/src/components/CacheProvider/utils.ts Show resolved Hide resolved
react-components/src/components/CacheProvider/utils.ts Show resolved Hide resolved
react-components/src/data-providers/FdmSDK.ts Show resolved Hide resolved
react-components/src/query/useModelsForInstanceQuery.ts Show resolved Hide resolved
react-components/src/query/useSearchAssetsMapped360Annotations.tsx Outdated Show resolved Hide resolved
react-components/src/query/useSearchAssetsMapped360Annotations.tsx Show resolved Hide resolved
react-components/src/query/useSearchAssetsMapped360Annotations.tsx Show resolved Hide resolved
danpriori
danpriori approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@haakonflatval-cognite haakonflatval-cognite changed the title fix(react-components): make react-components compatible with 360-CDM-changes in Reveal fix(react-components): make react-components compatible with 360-CDM-changes in Reveal and bump to 0.74.0 Jan 23, 2025
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) January 23, 2025 09:40
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jan 23, 2025
@haakonflatval-cognite haakonflatval-cognite merged commit 0773f27 into master Jan 23, 2025
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/react-components-360-conforming branch January 23, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpriori danpriori danpriori approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @danpriori