Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-23253] SAP writeback acls #2019

Merged
merged 6 commits into from
Nov 12, 2024
Merged

[CDF-23253] SAP writeback acls #2019

merged 6 commits into from
Nov 12, 2024

Conversation

doctrino
Copy link
Contributor

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino requested review from a team as code owners November 12, 2024 06:47
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (99a7c5a) to head (ccd94a2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2019   +/-   ##
=======================================
  Coverage   90.32%   90.33%           
=======================================
  Files         141      141           
  Lines       22135    22163   +28     
=======================================
+ Hits        19993    20020   +27     
- Misses       2142     2143    +1     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/capabilities.py 97.28% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider adding a test on the compare ACLs function as you’re adding a new Scope type

@doctrino doctrino merged commit ea8b81c into master Nov 12, 2024
16 checks passed
@doctrino doctrino deleted the sap-writeback-acls branch November 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants