Add workflow trigger upsert method, deprecated trigger create #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerstraeteBert
requested review from
vincent-cognite,
doctrino and
haakonvt
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
=======================================
Coverage 90.22% 90.23%
=======================================
Files 135 135
Lines 21573 21577 +4
=======================================
+ Hits 19465 19469 +4
Misses 2108 2108
|
haakonvt
reviewed
Sep 25, 2024
Comment on lines
+108
to
+110
| """`[DEPRECATED] Create or update a trigger for a workflow. <https://api-docs.cognite.com/20230101/tag/Workflow-triggers/operation/CreateOrUpdateTriggers>`_ | ||
|
|
||
| This method is deprecated, use '.upsert' instead. It will be completely removed October 2024. |
There was a problem hiding this comment.
Check out DatapointsAPI.retrieve_dataframe_in_tz for a deprecation warning that stands out
vincent-cognite
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
client.workflows.triggers.upsert, this allows upserts of triggers.Deprecated
client.workflows.triggers.create, as its functionality is covered by the newclient.workflows.triggers.upsertReplaces: #1944
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.