Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-22379] Hosted Extractors Source: Kafka and Rest #1899

Merged
merged 105 commits into from
Sep 24, 2024

Conversation

doctrino
Copy link
Contributor

Description

5/5

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

…art3

# Conflicts:
#	CHANGELOG.md
#	cognite/client/_version.py
#	pyproject.toml
#	tests/tests_integration/test_api/test_hosted_extractors/test_sources.py
…art4

# Conflicts:
#	cognite/client/_api/hosted_extractors/__init__.py
#	cognite/client/data_classes/hosted_extractors/__init__.py
#	cognite/client/testing.py
Base automatically changed from hosted-extractors-part4 to master September 24, 2024 14:03
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 89.15663% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (6a5da4e) to head (1cfdb6c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e/client/data_classes/hosted_extractors/sources.py 89.02% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   90.23%   90.21%   -0.03%     
==========================================
  Files         135      135              
  Lines       21405    21564     +159     
==========================================
+ Hits        19315    19453     +138     
- Misses       2090     2111      +21     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/_base.py 92.84% <100.00%> (ø)
.../client/data_classes/hosted_extractors/__init__.py 100.00% <ø> (ø)
...e/client/data_classes/hosted_extractors/sources.py 88.60% <89.02%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one must-fix snake_case typo left 😄

cognite/client/data_classes/hosted_extractors/sources.py Outdated Show resolved Hide resolved
@doctrino doctrino merged commit ed85431 into master Sep 24, 2024
14 checks passed
@doctrino doctrino deleted the hosted-extractors-part5 branch September 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants