-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback to global_config to allow tracking of one's own SDK usage #1469
base: master
Are you sure you want to change the base?
Conversation
Not run it yet, but expected code consolidating counters across threads/processes? Or does it require handling concurrency on callback side? Parallelism still confuses me every time :) |
Accidentally clicked close... 👀 |
@spex66 The callback will be called by the different threads executing the requests (the SDK only uses threading as a means of concurrency). In the two examples given in the docstring, they would all write to the same object, which is totally fine (GIL + ordering doesn't matter). Do you have a usage pattern in mind that you're afraid might have a race condition? |
492960c
to
0772ccc
Compare
@spex66 do you need this feature or should we put it on hold? |
Ok hold pls, and I need to set a reminder to look into it .. later |
…st to distinguish from APIClient method with same name
c3b208c
to
00fed0b
Compare
DRAFT
Ref. edm-pipeline debug discussion: @spex66 @thorkildcognite
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.