become compatible with incompatible_disable_starlark_host_transitions #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olsworn
requested review from
mikberg,
mortenmj and
psalaberria002
as code owners
| @@ -145,7 +145,7 @@ _snapshots_runner = rule( | |||
| attrs = { | |||
| "snapshots": attr.label( | |||
| default = "@snapshots-bin//:snapshots", | |||
| cfg = "host", | |||
| cfg = "target", | |||
There was a problem hiding this comment.
WHy is this one target while the other one is exec? Aren't both refering to the same binary?
There was a problem hiding this comment.
They are the same binary, however the way both binaries are used is different.
I could be wrong about this but:
In the case of _snapshots_runner, we are not running the executable during build phase, but at runtime.
Because we want the binary that snapshots_runner produces to use a binary that the machine runs the script will use.
Some documentation on the subject: https://bazel.build/extending/rules#configurations
psalaberria002
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--incompatible_disable_starlark_host_transitionswill become default with bazel 7.0This makes
cfg = "host"syntax illegalThread: bazelbuild/bazel#17032