-
-
Notifications
You must be signed in to change notification settings - Fork 95
Update to go v1.25.6 as standard version, and go mod updates #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted interactively.
… expected to fail -- will disable ones that randomly fail and file an issue.
Member
Author
|
@kkoreilly can you possibly look at the last CI run output and try to figure out why the test is saying FAIL at the end, with error code 1, when there are nothing but PASS results from the tests? |
…COLR tables which we don't know how to process. emoji font has those.
Member
Author
|
@kkoreilly it is now working. seems so random. anyway this PR is now ready to go -- please review! |
…rap for any text that contains carriage returns, so \ at end of line (or br) works properly.
…'t transfer across modules. verified that lab/docs and compcogneuro/web work, whereas they did not before. also, it uses -nogui instead of offscreen tags.
Member
Author
|
@kkoreilly I'm merging this because the updated core setup is needed for the other content repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.25 will soon be the older version as soon as 1.26 is released. There are various go security warnings that at least require updating to 1.24, and might as well just get ahead of the game.
This builds on imagebutton PR assuming that will be merged first.
I tested everything extensively locally, including core run web on docs and demo. Will be updating cogent code and using that for my standard continuous testing soon.