Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mini-spire into cofidectl #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move mini-spire into cofidectl #21

wants to merge 3 commits into from

Conversation

meyskens
Copy link
Contributor

Add mini-spire a lightweight development implementation of the SPIRE Workload API into cofidectl dev

@meyskens meyskens requested a review from markgoddard November 15, 2024 07:56
@meyskens
Copy link
Contributor Author

Depends on the still to open source go-sdk


auth := AuthInfo{}
sys.Control(func(fd uintptr) {
cred, err := syscall.GetsockoptUcred(int(fd), syscall.SOL_SOCKET, syscall.SO_PEERCRED)
Copy link
Contributor

@nialdaly nialdaly Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, just adding a comment here related to this issue tracked in cofide-cli.

The following errors occur while running just build on a MacBook Pro M3:

# github.com/cofide/cofide-cli/internal/pkg/spire-devserver
internal/pkg/spire-devserver/grpc-authinfo.go:57:24: undefined: syscall.GetsockoptUcred
internal/pkg/spire-devserver/grpc-authinfo.go:57:77: undefined: syscall.SO_PEERCRED

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nialdaly can you try again? i disabled this code on non-linux platforms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing those errors anymore 😃 I am seeing these though, also on GitHub Actions just now:

=== Failed
=== FAIL: cmd/cofidectl  (0.00s)
FAIL    github.com/cofide/cofidectl/cmd/cofidectl [build failed]

=== FAIL: cmd/cofidectl/cmd  (0.00s)
FAIL    github.com/cofide/cofidectl/cmd/cofidectl/cmd [build failed]

=== FAIL: cmd/cofidectl/cmd/dev  (0.00s)
FAIL    github.com/cofide/cofidectl/cmd/cofidectl/cmd/dev [build failed]

=== FAIL: internal/pkg/dev/minispire  (0.00s)
FAIL    github.com/cofide/cofidectl/internal/pkg/dev/minispire [build failed]

=== Errors
internal/pkg/dev/minispire/workload.go:242:67: undefined: id
internal/pkg/dev/minispire/workload.go:260:9: undefined: id

DONE 255 tests, 4 failures, 2 errors in 1.017s
exit status 1
error: Recipe `test` failed on line 12 with exit code 1

Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants