Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.0 #26

Merged
merged 15 commits into from
May 6, 2024
Merged

1.1.0 #26

merged 15 commits into from
May 6, 2024

Conversation

codyduong
Copy link
Owner

@codyduong codyduong commented Apr 2, 2024 •
edited
Loading

  • Resolves Find-AliasTips is required for more complex aliases #25
  • Adds message when removing alias-tips
    image
  • Chore: LICENSE
  • Resolves function introspection being run even when it shouldn't have been
  • Resolves Bug with empty command #27
  • Resolves Add PSScriptAnalyzer github action #7
  • Choose most covering alias first, then shorter alias as tie breaker (ie. choose the alias that removes the most from the command string, then if tiebreaker necessary choose the shorter alias. prefers longer aliases with more "coverage" rather than shorter ones, even if those two aliases would be shorter combined than the one and remaining), besides as a point of discussion the technical implementation of this would be a whole writeup, and the productivity gained would be minimal

@codyduong codyduong added the bug Something isn't working label Apr 2, 2024
@codyduong codyduong self-assigned this Apr 2, 2024
@codyduong codyduong changed the title Resolves #25 1.1.0 Apr 2, 2024
@codyduong codyduong mentioned this pull request Apr 2, 2024
Open
@codyduong codyduong added the documentation Improvements or additions to documentation label Apr 2, 2024
codyduong
codyduong commented Apr 2, 2024
View reviewed changes
alias-tips/alias-tips.psd1 Outdated Show resolved Hide resolved
codyduong added 2 commits April 2, 2024 17:34
@codyduong
Fix issues with parsing
0214a07 
* Resolves function introspection being called when it shouldn't have
  been
* Adds tests to Find-Alias
* Improve documentation
@codyduong
Resolves #27
d77640a
codyduong
codyduong commented Apr 4, 2024
View reviewed changes
tests/unit/Find-Alias.tests.ps1 Outdated Show resolved Hide resolved
tests/unit/Find-Alias.tests.ps1 Outdated Show resolved Hide resolved
alias-tips/alias-tips.psd1 Outdated Show resolved Hide resolved
@github-advanced-security

This comment was marked as outdated.

Sign in to view
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 11, 2024
View reviewed changes
alias-tips/Private/Find-AliasCommand.ps1 Fixed Show fixed Hide fixed
alias-tips/Private/Find-AliasCommand.ps1 Fixed Show fixed Hide fixed
alias-tips/Private/Find-AliasCommand.ps1 Fixed Show fixed Hide fixed
alias-tips/Private/Find-RegexThreadJob.ps1 Fixed Show fixed Hide fixed
alias-tips/Private/Find-RegexThreadJob.ps1 Fixed Show fixed Hide fixed
alias-tips/Public/PSConsoleHostReadLine.ps1 Fixed Show fixed Hide fixed
tests/unit/Find-Alias.tests.ps1 Fixed Show fixed Hide fixed
tests/unit/Find-Alias.tests.ps1 Fixed Show fixed Hide fixed
tests/unit/Find-Alias.tests.ps1 Fixed Show fixed Hide fixed
tests/unit/Find-Alias.tests.ps1 Fixed Show fixed Hide fixed
@codyduong codyduong merged commit c940714 into master May 6, 2024
2 checks passed
@codyduong codyduong deleted the patch-25 branch May 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@codyduong codyduong

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
1 participant
@codyduong