Fixed DynamicOneDimensionalArray's length function #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@czgdp1807 windows-latest, 3.8 and macos-latest, 3.10 CI have also encountered failures. Expand and check the run tests section. However the CI check passes. It should fail. Isn't this weird? ubuntu-latest also got the same failures, and it failed. The others passed |
|
@Naveen-Pal Try looking at places where len() was used for DODA. We will have to fix it there too. Because if len() was used in some other algo/test, that is bound to fail as we have changed the answer of len() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Fixes #557 "
Brief description of what is fixed or changed
Added a length function to obtain correct length of Dynamic array