feat: add basic smoketest functionality #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
NautiluX
reviewed
Dec 19, 2025
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
NautiluX
approved these changes
Jan 23, 2026
Member
NautiluX
left a comment
NautiluX
left a comment
There was a problem hiding this comment.
couple of structural questions, besides that, I like it :)
| Name() string | ||
| } | ||
|
|
||
| type SmoketestCodesphereOpts struct { |
Member
There was a problem hiding this comment.
is there a specific reason this is defined here, not with the Cmd?
| } | ||
|
|
||
| type SmoketestCodesphereOpts struct { | ||
| Client codesphere.Client |
Member
There was a problem hiding this comment.
I'm surprised this is at the opts struct not the cmd, since usually the opts represent the options given to the command. What's the reason for this choice?
| service: | ||
| steps: | ||
| - name: Run php server | ||
| command: php -S 0.0.0.0:3000 index.html |
|
|
||
| func (c *SmoketestCodesphereCmd) RunE(_ *cobra.Command, args []string) error { | ||
| // Initialize client if not set (for testing) | ||
| if c.Opts.Client == nil { |
Member
There was a problem hiding this comment.
when would this be not the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp: https://app.clickup.com/t/869au15v2