allow writing snapshot on top of existing files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
force-pushed
the
codesandbox/memory-save-snapshot
branch
from
cf68a98 to
f3b8fa6
Compare
Logic for writing a frame to a descriptor chain was a bit convoluted. Signed-off-by: Babis Chalios <[email protected]>
Use notification suppression feature of VirtIO for net device. Signed-off-by: Babis Chalios <[email protected]>
Instead of keeping track whether we have consumed any descriptors in a separate variable, rely on `prepare_kick()` to find out whether we should enable guest notifications. This will probably induce a performance hit with guests that don't support notification suppression, but it simplifies the code in the common case. Signed-off-by: Babis Chalios <[email protected]>
One notification-suppression related unit test and some more additions to increase total code coverage. Signed-off-by: Babis Chalios <[email protected]>
On Firecracker v1.1.0 we add support for notification suppression in the VirtIO net device, which renders making snapshots for older versions incompatible. This commit forbids snapshots to v1.0.0 if the net device uses notification suppression and adapts integration tests to reflect the incompatibility. Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
Fixes these warnings when running the tests: Signed-off-by: Pablo Barbáchano <[email protected]>
ref: firecracker-microvm#1233 Signed-off-by: Ján Mochňak <[email protected]>
Signed-off-by: Alexandru-Cezar Sardan <[email protected]>
Signed-off-by: Alexandru-Cezar Sardan <[email protected]>
Signed-off-by: Matthew Schlebusch <[email protected]>
See https://rustsec.org/advisories/RUSTSEC-2020-0157 Signed-off-by: Matthew Schlebusch <[email protected]>
Signed-off-by: Alexandru-Cezar Sardan <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]> shorter
Signed-off-by: Arjun Ramachandrula <[email protected]>
Signed-off-by: Arjun Ramachandrula <[email protected]>
This makes it much easier to view the dependency changes whenever introduced. Signed-off-by: alindima <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Replace mmio::Error::IrqExhausted with vm-allocator error. Signed-off-by: Jonathan Woollett-Light <[email protected]>
Replace old logic for irq numbers allocation with the IdAllocator component from vm-allocator crate. Signed-off-by: Jonathan Woollett-Light <[email protected]>
Replace the old logic for mmio slots allocation with the AddressAllocator component from vm-allocator component. Also restored the AddressAllocator on restore path. Signed-off-by: Jonathan Woollett-Light <[email protected]> Co-authored-by: Alexandru Cihodaru <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Added constants and source references for legacy device handling with `PortIODeviceManager`. Signed-off-by: Jonathan Woollett-Light <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Signed-off-by: Pablo Barbáchano <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Signed-off-by: Jonathan Woollett-Light <[email protected]>
Signed-off-by: CuriousCorrelation <[email protected]>
Signed-off-by: CuriousCorrelation <[email protected]>
Signed-off-by: CuriousCorrelation <[email protected]>
CompuIves
force-pushed
the
codesandbox/memory-save-snapshot
branch
from
f3b8fa6 to
62db03e
Compare
Signed-off-by: Ives van Hoorne <[email protected]>
CompuIves
force-pushed
the
codesandbox/memory-save-snapshot
branch
from
94030d2 to
18c70af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.