Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md (add my name) #2441

Closed
wants to merge 2 commits into from
Closed

Update README.md (add my name) #2441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a55e58f
Update README.md (add my name)
zafar-Alee Nov 2, 2024
f3c7f1c
Update README.md (added my name)
zafar-Alee Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,13 @@ If you encounter any issues while setting up or using VigyBag, try the following

## 😍 Our Contributors : <a name="contributors"></a>

<a href="https://github.com/codervivek5/VigyBag/graphs/contributors">
<img src="https://contrib.rocks/image?repo=codervivek5/VigyBag" />
</a>

<table>
<tr>
<td><img src="https://avatars.githubusercontent.com/u/176493940?v=4" width="100px"alt="Zafar Ali""/></td>
<p><a href="https://github.com/zafar-Alee" target="_blank"> Zafar Ali</a></p>
</p>
</table>
Comment on lines +283 to +289
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix HTML structure in the contributor table.

The contributor table has several HTML structure issues:

  1. Missing closing </tr> tag
  2. Misplaced <p> tag that should be inside a <td>
  3. Extra quote in the image alt text

Apply this diff to fix the HTML structure:

 <table>
   <tr>
     <td><img src="https://avatars.githubusercontent.com/u/176493940?v=4" width="100px"alt="Zafar Ali""/></td>
-    <p><a href="https://github.com/zafar-Alee" target="_blank"> Zafar Ali</a></p>
-  </p>
+    <td><a href="https://github.com/zafar-Alee" target="_blank">Zafar Ali</a></td>
+  </tr>
 </table>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<table>
<tr>
<td><img src="https://avatars.githubusercontent.com/u/176493940?v=4" width="100px"alt="Zafar Ali""/></td>
<p><a href="https://github.com/zafar-Alee" target="_blank"> Zafar Ali</a></p>
</p>
</table>
<table>
<tr>
<td><img src="https://avatars.githubusercontent.com/u/176493940?v=4" width="100px"alt="Zafar Ali""/></td>
<td><a href="https://github.com/zafar-Alee" target="_blank">Zafar Ali</a></td>
</tr>
</table>


Made with [contrib.rocks](https://contrib.rocks).

Expand Down