Association demo #28
Merged
Association demo #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* resolve #11: phisically remove bin directory * resolve #11: add bin to .gitignore * resolve #11: update Dockefile Updated dockerfile to copy UT target as well. Needed in order to pass CI after phisical UT binary removal * resolve #11: update CI As desktop-business-app-ut target is removed, removed one step - direct call of unit tests run. Rationale: unit tests are run already during docker-build step. Therefore CI .yaml file name was updated
BaqWin
force-pushed
the
association-demo
branch
from
cb8f532
to
8697e9e
Compare
fbtom
requested changes
Mar 13, 2024
|
Thanks @fbtom for Code Review. |
Aleksiiej
reviewed
Mar 13, 2024
|
Thanks @Aleksiiej for Code Review. |
fbtom
reviewed
Mar 13, 2024
|
Thanks @fbtom for Code Review. |
Aleksiiej
reviewed
Mar 13, 2024
|
Thanks @Aleksiiej for Code Review. |
mBialczak
previously requested changes
Mar 13, 2024
|
Thanks @mBialczak for Code Review. |
This was referenced Mar 14, 2024
fbtom
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Lgfm.
In next changes please separate CMakeLists.txt as @mBialczak mentioned
Each directory should have it's own
/src/app/doctor/CMakeLists.txt
then tests for each class
/src/app/doctor/test/CMakeLists.txt
|
Thanks @fbtom for Code Review. |
|
Thanks @mBialczak for Code Review. |
fbtom
dismissed
mBialczak’s stale review
Let's merge this code and provide apropiate changes with next PRs
|
Your PR was merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the initial framework for the Person, Doctor, and Visit classes.
Added association between the Doctor and Visit classes.
Integrated an extent feature into the Visit class.
Made simple and introductory tests for associations and extent.
#16
#17
#18