Introduce receptionist and staff tests #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mBialczak
reviewed
Jun 14, 2024
| namespace receptionist | ||
| { | ||
|
|
||
| class ReceptionistMock : public iReceptionist |
There was a problem hiding this comment.
I think, that Mocks should reside in "tests" module, not in backend. It does not need to be included in production code in my opinion, as it is part of "testing" world.
The best option in my opinion is to create folder "Mocks" or "utils/mocks" in "tests" module
There was a problem hiding this comment.
I thought about it also but wasn't sure. In different projects I followed this approach, so I added it here also. Will move it to utils/mocks under the test module (will need help haha :) )
|
Thanks @mBialczak for Code Review. |
|
Thanks @mBialczak for Code Review. |
1 similar comment
|
Thanks @mBialczak for Code Review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request:
Receptionist class was introduced.
Doctor Factory was created.
Doctor Mock was created.
Receptionist Mock was created.
Staff tests were introduced with getters for Doctor and Receptionist in Staff class.