Skip to content

Commit 01dbfae

Browse files
committed
#5107: Fix a crash related to project setup changes, due to concurrent calls of SceneGraph::boundsChanged by both the eclass def loader and the material manager realisation thread.
This commit doesn't make it thread-safe, but the call to SceneGraph::boundsChanged is actually unnecessary when just the face shader has been changed.
1 parent ac0ed1f commit 01dbfae

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

radiantcore/brush/Brush.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,8 @@ void Brush::onFacePlaneChanged()
480480

481481
void Brush::onFaceShaderChanged()
482482
{
483-
onFacePlaneChanged();
483+
// When the face shader changes, no geometry change is happening
484+
// therefore no call to onFacePlaneChanged() is necessary
484485

485486
// Queue an UI update of the texture tools if any of them is listening
486487
signal_faceShaderChanged().emit();

0 commit comments

Comments
 (0)