Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Launch Bounds #144

Open
wants to merge 7 commits into
base: sycl-develop
Choose a base branch
from
Open

Add Launch Bounds #144

wants to merge 7 commits into from

Conversation

AD2605
Copy link
Collaborator

@AD2605 AD2605 commented Oct 18, 2024 •
edited
Loading

Small PR to add Launch bounds to the cuda launch.
Also force inlines the device_kernel which leads to no call instructions.

This increases the performance in the benchmarks, making the SYCL path, roughly equal or better than the CUDA one

aacostadiaz
aacostadiaz reviewed Oct 21, 2024
View reviewed changes
cmake/FindDPCPP.cmake Outdated Show resolved Hide resolved
aacostadiaz
aacostadiaz approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-goli mehdi-goli mehdi-goli left review comments

@aacostadiaz aacostadiaz aacostadiaz approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AD2605 @mehdi-goli @aacostadiaz