Double wildcard paths like collection** on change events (missing return value)#4
Open
treet wants to merge 1 commit intocodeparty:masterfrom
Open
Double wildcard paths like collection** on change events (missing return value)#4treet wants to merge 1 commit intocodeparty:masterfrom
treet wants to merge 1 commit intocodeparty:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't get hooks like
store.allow('change', 'collection**')orstore.allow('change', 'collection.**')to work, any validations added on such paths will never trigger.store.allow('all', 'collection**')still triggers fine, which I think has to do with_allow_allchecking manually for those kind of paths. Are these patterns not available for change events? Is the missing return value a bug or was it intended?How can I capture all changes under a specific collection?
(Edit: I just realised these changes are wrong, relativePath should perhaps return something like
[null].concat(relativeSegments)?)