Go Live 🚀 #21
Go Live 🚀 #21
Conversation
add sidebar/nav and routes Co-authored-by: Amr Ahmed
Final touches
|
Hi @Amrhub, @AlexRS90, @codepantha, @micheaol, While you made a great effort in this project, unfortunately, I cannot proceed to review your code. Invalid Code Review RequestYou have submitted a project that does not have a PR description, which is very important for who is reviewing it. For example, do you have a back-end PR for me to review or is it only the front-end? Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. |
There was a problem hiding this comment.
Hi @Amrhub, @AlexRS90, @codepantha, @micheaol,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Suggested changes
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- Write tests for your app, since it's a very good practice.
Highlights
- Your project is pretty amazing, I really loved the design and your code is clean.
- Professional repository.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
src/redux/reducers/doctor.js
Outdated
| const doctorReducer = (state = initialState, { type, payload }) => { | ||
| switch (type) { | ||
| case FETCH_DOCTOR_SUCCESS: | ||
| // cacheDoctors = payload; |
There was a problem hiding this comment.
Hi @MuriloRoque 👋
Thank you for your review 🙏 In the case of the testing, we literally forgot about it and we do not have enough time to implement them. We couldn't submit this PR and get a review on time due to the bug on the dashboard. Now it's less than 2 hours to the presentation and there is no time to implement the testing. We will ensure to do it in the near future.
|
Hi @Amrhub, @codepantha, @AlexRS90, @micheaol, In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it Good luck! 🎉 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. |
Feat/slider
The MedBook App is a SPA built with React, the user is able to:
✅ Sign Up ✍️
✅ Add doctor 👨⚕️
✅ Book appointments 📆
✅ See all its appointments 🗓️
✅ Delete a doctor, even if it has appointments👨⚕️ ❌
We are using MedBook API to store all information related to our app. 🌐
Of course, our APP is responsive so, feel free to use it on any device! 📱 💻 🖥️
Do you prefer the dark side ❓
Awesome you can join us using our dark theme 🌑
Try it out ⬇️ ⬇️
Live Demo
Enjoy!